felix/photobooth
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Enclosed config changes in setActive/setIdle in try-catch-blocks to avoid crashes with Nikon cameras (fixes #55)

Browse Source
This commit is contained in:
Balthasar Reuter
2019-01-12 21:31:34 +01:00
parent c3f4d5e669
commit 7df2fd66c3
2 changed files with 22 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
photobooth/camera/CameraGphoto2.py
View File

@@ -136,15 +136,21 @@ class CameraGphoto2(CameraInterface):
def setActive(self): def setActive(self):
config = self._cap.get_config() try:
config.get_child_by_name('output').set_value('PC') config = self._cap.get_config()
self._cap.set_config(config) config.get_child_by_name('output').set_value('PC')
self._cap.set_config(config)
except BaseException as e:
logging.warn('Error while setting camera output to active: {}.'.format(e))
def setIdle(self): def setIdle(self):
config = self._cap.get_config() try:
config.get_child_by_name('output').set_value('Off') config = self._cap.get_config()
self._cap.set_config(config) config.get_child_by_name('output').set_value('Off')
self._cap.set_config(config)
except BaseException as e:
logging.warn('Error while setting camera output to idle: {}.'.format(e))
def getPreview(self): def getPreview(self):

14
photobooth/camera/CameraGphoto2Cffi.py
View File

@@ -106,13 +106,19 @@ class CameraGphoto2Cffi(CameraInterface):
def setActive(self): def setActive(self):
self._cap._get_config()['actions']['viewfinder'].set(True) try:
self._cap._get_config()['settings']['output'].set('PC') self._cap._get_config()['actions']['viewfinder'].set(True)
self._cap._get_config()['settings']['output'].set('PC')
except BaseException as e:
logging.warn('Error while setting camera output to active: {}.'.format(e))
def setIdle(self): def setIdle(self):
self._cap._get_config()['actions']['viewfinder'].set(False) try:
self._cap._get_config()['settings']['output'].set('Off') self._cap._get_config()['actions']['viewfinder'].set(False)
self._cap._get_config()['settings']['output'].set('Off')
except BaseException as e:
logging.warn('Error while setting camera output to idle: {}.'.format(e))
def getPreview(self): def getPreview(self):