diff --git a/src/DoresA/db.py b/src/DoresA/db.py index 7f7dcd0..a623dcf 100644 --- a/src/DoresA/db.py +++ b/src/DoresA/db.py @@ -55,20 +55,24 @@ def mariadb_insert_log(csv_entry): def mariadb_insert_logs(csv_entries): inserts_sql = 'INSERT INTO ' + sql_table_name + ' (timestamp, domain, type, record, ttl) VALUES ' - for i in range(len(csv_entries) - 1): - inserts_sql += '(%s, %s, %s, %s, %s), ' - - inserts_sql += '(%s, %s, %s, %s, %s)' values = [] for csv_entry in csv_entries: - values += [convert_timestamp_to_sql_datetime(float(csv_entry[0])), csv_entry[1], - csv_entry[2], csv_entry[3], csv_entry[4]] + try: + values += [convert_timestamp_to_sql_datetime(float(csv_entry[0])), csv_entry[1], + csv_entry[2], csv_entry[3], csv_entry[4]] + inserts_sql += '(%s, %s, %s, %s, %s), ' + except IndexError: + print('index error for csv entry: ' + csv_entry) + pass + + # remove last comma for sql compatibility + inserts_sql = inserts_sql[:-2] try: sql_cursor.execute(inserts_sql, values) except Exception: - print('something happened') # TODO proper error handling + print('could not insert entry: ' + values) # TODO proper error handling pass sql_connection.commit()